Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argocd diff shows no diff when secret key deleted #16986

Open
3 tasks done
lcc3108 opened this issue Jan 25, 2024 · 5 comments
Open
3 tasks done

argocd diff shows no diff when secret key deleted #16986

lcc3108 opened this issue Jan 25, 2024 · 5 comments
Labels
bug Something isn't working component:application-sets Bulk application management related type:bug version:2.13 Latest confirmed affected version is 2.13

Comments

@lcc3108
Copy link

lcc3108 commented Jan 25, 2024

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

We manage the secret of the application as argocd.

When I deleted the secret, the diff didn't come up, so I found a problem with the previous version of manifest being applied as it was.

To Reproduce

  1. Update github code to show yaml file below
apiVersion: v1
data:
  CACHE_REDIS_PASSWORD: ++++++++
  STATISTIC_POSTGRES_DB: ++++++++
  STATISTIC_POSTGRES_PASSWORD: ++++++++
  STATISTIC_POSTGRES_USER: ++++++++
kind: Secret
metadata:
  name: statistic-consumer
type: Opaque
  1. Synchronize to argocd

3.Update the contents of CACHE_REDIS_PASSWORD key

Expected behavior
argocd detect diff and remove secret key CACHE_REDIS_PASSWORD
Screenshots
live
image
desired
image
but no diff
image

Version

{
"Version": "v2.8.4+c279299",
"BuildDate": "2023-09-13T19:12:09Z",
"GitCommit": "c27929928104dc37b937764baf65f38b78930e59",
"GitTreeState": "clean",
"GoVersion": "go1.20.6",
"Compiler": "gc",
"Platform": "linux/amd64",
"KustomizeVersion": "v5.1.0 2023-06-19T16:58:18Z",
"HelmVersion": "v3.12.1+gf32a527",
"KubectlVersion": "v0.24.2",
"JsonnetVersion": "v0.20.0"
}

Logs

Paste any relevant application logs here.
@lcc3108 lcc3108 added the bug Something isn't working label Jan 25, 2024
@ligol
Copy link

ligol commented Mar 20, 2024

We also are encountering this issue on secret and configmap, and can't be sure that our secret are correctly in sync when we deploy if we don't do a destroy and recreate on them. Any information or way to fix this?

Another issue exist for the ConfigMap: #16092

@alexmt alexmt added bug/in-triage This issue needs further triage to be correctly classified component:application-sets Bulk application management related type:bug labels Jul 1, 2024
@jsalatiel
Copy link

Are you using controller.diff.server.side: "true" ?

@ligol
Copy link

ligol commented Oct 4, 2024

No we aren't, we are going to try and validate if it fix the issue for us, thanks

@andrii-korotkov-verkada
Copy link
Contributor

ArgoCD versions 2.10 and below have reached EOL. Can you upgrade and let us know if the issue is still present, please?

@andrii-korotkov-verkada andrii-korotkov-verkada added the version:EOL Latest confirmed affected version has reached EOL label Nov 11, 2024
@sergeyshevch
Copy link

sergeyshevch commented Dec 18, 2024

@andrii-korotkov-verkada I see same behaviour in v2.13.2+dc43124 with SSA and Server-Side Diff

At same time if I disable Server Side diff then everything works correctly.

@andrii-korotkov-verkada andrii-korotkov-verkada added version:2.13 Latest confirmed affected version is 2.13 and removed bug/in-triage This issue needs further triage to be correctly classified version:EOL Latest confirmed affected version has reached EOL labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:application-sets Bulk application management related type:bug version:2.13 Latest confirmed affected version is 2.13
Projects
None yet
Development

No branches or pull requests

6 participants