tests: add argocd 2.2.5 to test suite #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbse
force-pushed
the
add-220-acceptance-tests
branch
from
a61ed5e to
a7188bb
Compare
oboukili
requested changes
Feb 23, 2022
.github/workflows/tests.yml
Outdated
| @@ -14,7 +14,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| argocd_version: ["v2.1.3", "v2.0.5", "v1.8.7"] | |||
| argocd_version: ["v2.2.5", "v2.1.3", "v2.0.5", "v1.8.7"] | |||
There was a problem hiding this comment.
We can remove v1.x indeed. Can you use the following:
Suggested change
| argocd_version: ["v2.2.5", "v2.1.3", "v2.0.5", "v1.8.7"] | |
| argocd_version: ["v2.2.5", "v2.1.10"] |
There was a problem hiding this comment.
Updated based on your feedback.
alxbse
force-pushed
the
add-220-acceptance-tests
branch
from
a7188bb to
37ff9dc
Compare
oboukili
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that the provider works with the current version. Version 2.2.5 is added without any older versions being removed increasing the workflows executed. As per #141 I found it unclear which versions the provider should maintain compatibility with.