Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONFIG] argilla server: Review and update dependencies #5649

Merged
merged 23 commits into from
Nov 4, 2024

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Oct 29, 2024

Description

  • Use the newer version of python
  • Use the latest version of core dependencies. (without code changes)
  • Upgrade docker images
  • Remove unnecessary dependencies.

Type of change

  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon changed the title [CONFIG] argilla server: Review and update dependencies [WIP] [CONFIG] argilla server: Review and update dependencies Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.20%. Comparing base (02413d1) to head (b184802).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
argilla-server/src/argilla_server/enums.py 85.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5649      +/-   ##
===========================================
- Coverage    91.23%   91.20%   -0.04%     
===========================================
  Files          150      150              
  Lines         6250     6250              
===========================================
- Hits          5702     5700       -2     
- Misses         548      550       +2     
Flag Coverage Δ
argilla-server 91.20% <85.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon changed the title [WIP] [CONFIG] argilla server: Review and update dependencies [CONFIG] argilla server: Review and update dependencies Oct 30, 2024
Copy link
Member

@jfcalvo jfcalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added some questions.

argilla-server/pyproject.toml Show resolved Hide resolved
argilla-server/pyproject.toml Show resolved Hide resolved
argilla-server/pyproject.toml Outdated Show resolved Hide resolved
Comment on lines +16 to +19
try:
from enum import StrEnum
except ImportError:
from enum import Enum
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@frascuchon frascuchon merged commit 3b1133a into develop Nov 4, 2024
1 of 2 checks passed
@frascuchon frascuchon deleted the chore/argilla-server/update-deps branch November 4, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants