Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friday and next Friday in Monday doesn't work #81

Closed
dariuszkowalski-com opened this issue Jan 10, 2022 · 4 comments · Fixed by #83
Closed

Friday and next Friday in Monday doesn't work #81

dariuszkowalski-com opened this issue Jan 10, 2022 · 4 comments · Fixed by #83

Comments

@dariuszkowalski-com
Copy link

Example 1:

  • I am in monday - 2022-01-10
  • Monday is set as a first day of week
  • I enter friday, select it and run
    image
  • text is translated tu [[2022-01-07]]
    • expected: [[2022-01-14]]

Example 2:

  • I am in monday - 2022-01-10
  • Monday is set as a first day of week
  • I enter next friday, select it and run
    image
  • text is translated tu [[2022-01-21]]
    • expected: [[2022-01-14]]

Is it a bug?

@ScottKillen
Copy link

I experienced something similar:

  • Sunday is set as the first day of the week.
  • Today is Tuesday 2022-01-18.
  • @thursday renders 2022-01-13. I expect 2022-01-20.
  • @next Thursday renders 2022-01-27.
  • @last Thursday renders 2022-01-13.
  • @this Thursday renders 2022-01-20.

I expect that @Thursday and @this Thursday would be synonymous. This is certainly how it works in natural language.

@Gnopps
Copy link

Gnopps commented Jan 24, 2022

I experienced something similar:

* Sunday is set as the first day of the week.

* Today is Tuesday 2022-01-18.

* `@thursday` renders 2022-01-13. I expect 2022-01-20.

* `@next Thursday` renders 2022-01-27.

* `@last Thursday` renders 2022-01-13.

* `@this Thursday` renders 2022-01-20.

I expect that @Thursday and @this Thursday would be synonymous. This is certainly how it works in natural language.

This is similar to what I asked for here. Basically that "Thursday" renders next Thursday and not last Thursday.

The underlying engine "chrono" supports this with a setting, so ought to be fairly easy to implement.

@ScottKillen
Copy link

This is similar to what I asked for here. Basically that "Thursday" renders next Thursday and not last Thursday.

Yes, that setting would certainly fix it.

@ScottKillen
Copy link

@Gnopps

He manipulates the flag here, but I think there is a problem with the logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants