Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option in my_user_config.h to turn on SDM630 import active energy #9124

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Add option in my_user_config.h to turn on SDM630 import active energy #9124

merged 1 commit into from
Oct 3, 2020

Conversation

jkostorz
Copy link
Contributor

@jkostorz jkostorz commented Aug 18, 2020

Description:

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.1
  • The code change is tested and works on core ESP32 V.1.12.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@@ -637,6 +637,7 @@
#define SDM120_SPEED 2400 // SDM120-Modbus RS485 serial speed (default: 2400 baud)
//#define USE_SDM630 // Add support for Eastron SDM630-Modbus energy monitor (+0k6 code)
#define SDM630_SPEED 9600 // SDM630-Modbus RS485 serial speed (default: 9600 baud)
//#define SDM630_IMPORT // Show import active energy in MQTT and Web (+0k3 code)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this setting depend on USE_SDM630 somehow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, Tasmota reads multiple ModBus registers from SDM630 but without 0x015A, 0X015C, 0x015E (phase 1, 2 and 3 import active energy). I have been using the extended version that reads these registers for four months now and it works very well. For users who need to read the consumed energy separately for each phase, there is this switch - #SDM630_IMPORT. This works ONLY if the SDM630 is compiled in the firmware as before (tasmota-sensors etc).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I mean, does the code compile if SDM630_IMPORT is defined but USE_SDM630 is not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDM630_IMPORT work only if USE_SDM630 is defined.

@arendst arendst added the on hold by dev team Result - Feature request put on hold by member of development team label Aug 23, 2020
@jkostorz jkostorz closed this Sep 1, 2020
@jkostorz jkostorz reopened this Sep 1, 2020
@jkostorz jkostorz closed this Sep 12, 2020
@jkostorz jkostorz reopened this Sep 12, 2020
@arendst arendst merged commit d0028eb into arendst:development Oct 3, 2020
arendst added a commit that referenced this pull request Oct 3, 2020
Add SDM630 three phase ImportActive Energy display when ``#define SDM630_IMPORT`` is enabled by Janusz Kostorz (#9124)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold by dev team Result - Feature request put on hold by member of development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants