Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berry add 'bytes().appendhex()' #22767

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

s-hadinger
Copy link
Collaborator

Description:

Berry:

  • add bytes().appendhex() used in async webserver to create an hex payload without allocating a new object
  • reverting Berry allow 'bytes().append(nil)' #22758 which is not needed after all, and not fortunate

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241206
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit 77d9886 into arendst:development Jan 5, 2025
59 checks passed
@s-hadinger s-hadinger deleted the berry_bytes_appendhex branch January 6, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant