Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matter improve encoding of attributes to reduce flash size #21864

Merged

Conversation

s-hadinger
Copy link
Collaborator

Description:

Matter change the internal encoding of attributes per clusters to use bytes instead of arrays. Not functional change.

Size code reduction: 17.8KB

Details:

Before, attributes were encoded with a map of lists:

{
  768: [0, 1, 0xFFF9, 0xFFFA, 0xFFFB, 0xFFFC, 0xFFFD],
 [...]
}

Now attributes are in a packed bytes buffer of 16-bit unsigned integers in Big Endian:

{
  768: bytes('00000001FFF9FFFAFFFBFFFCFFFD'),
 [...]
}

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.7
  • The code change is tested and works with Tasmota core ESP32 V.3.0.2
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit a9a55b3 into arendst:development Jul 28, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant