Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 Platform 2024.05.13 #21524

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

Jason2866
Copy link
Collaborator

Description:

reverts Arduino PR 9453 WiFiClient - rename flush() to clear()
which brakes many used libraries.

@arendst needs right after merging reverting of the relevant Tasmota commits

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.3.0.0
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

reverts Arduino PR 9453 `WiFiClient - rename flush() to clear()`
@arendst
Copy link
Owner

arendst commented May 29, 2024

Step 1: Let's wait for CI to finish.
Step 2: I will revert my PR's which would still compile fine.
Step 3: Merge this PR.

I'll do the steps.

@arendst arendst merged commit d134b88 into arendst:development May 29, 2024
59 checks passed
@Jason2866 Jason2866 deleted the pltfrm_20240513 branch May 29, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants