Avoid connection errors when switching to safeboot to upload OTA firmware #21428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix occasional connection error when flashing ESP32 firmware via file upload.
Explanation: when uploading a new firmware with file upload, the first step is to restart Tasmota and switch to Safeboot partition. The browser polls the Tasmota device until it reboots and confirms that the safeboot is the active partition.
The partition switch is done by calling
/u4?u4=fct&api="
which returnsfalse
if the partition is the normal one (and forces reboot) andtrue
if it's the safeboot.As soon as
true
is received, the browser send aPOST
request to upload the firmware. The problem is that sometimes thePOST
is sent too soon. I'm not sure why but the webserver initialization does not seem to be complete.This patch adds a delay of 1 second between the confirmation of safeboot switch and sending the firmware.
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass