Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NeoPool NPHydrolysis percent and unit #19924

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

curzon01
Copy link
Contributor

@curzon01 curzon01 commented Nov 4, 2023

Description

  • NPHydrolysis also accepts percentage values as parameters (<level> {%}), even for devices using g/h
  • telemetry message SENSOR now always contains the values in percent in addition to the unit:
   "Hydrolysis": {
      "Data": 4.8,
      "Unit": "g/h",
      "Setpoint": 12,
      "Max": 16,
      "Percent": {
        "Data": 30,
        "Setpoint": 75
      },

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • I accept the CLA.

@arendst arendst merged commit 5d43306 into arendst:development Nov 4, 2023
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants