Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PID compile error #19896

Closed
7 tasks
krishy2 opened this issue Nov 1, 2023 · 2 comments
Closed
7 tasks

PID compile error #19896

krishy2 opened this issue Nov 1, 2023 · 2 comments

Comments

@krishy2
Copy link

krishy2 commented Nov 1, 2023

PROBLEM DESCRIPTION

A clear and concise description of what the problem is.

Custom build of the firmware fails if PID is defined.

REQUESTED INFORMATION

Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!

  • [ x] Read the Contributing Guide and Policy and the Code of Conduct
  • [ x] Searched the problem in issues
  • [ x] Searched the problem in discussions
  • [ x] Searched the problem in the docs
  • [ x] Searched the problem in the chat
  • Device used (e.g., Sonoff Basic): _____
  • [ x] Tasmota binary firmware version number used: _____13.2.0.1 development
    • Pre-compiled
    • [ x] Self-compiled
  • Flashing tools used: _____
  • Provide the output of command: Backlog Template; Module; GPIO 255:
  Configuration output here:

  • If using rules, provide the output of this command: Backlog Rule1; Rule2; Rule3:
  Rules output here:

  • Provide the output of this command: Status 0:
  STATUS 0 output here:

  • Set weblog to 4 and then, when you experience your issue, provide the output of the Console log:
  Console output here:

TO REPRODUCE

Steps to reproduce the behavior:

EXPECTED BEHAVIOUR

A clear and concise description of what you expected to happen.

SCREENSHOTS

If applicable, add screenshots to help explain your problem.

ADDITIONAL CONTEXT

Add any other context about the problem here.

xdrv_49_pid.ino line 469:

const char HTTP_PID_HL[] /PROGMEM/ = "{s}


{m}
{e}";
const char HTTP_PID_INFO[] /PROGMEM/ = "{s}" D_PID_DISPLAY_NAME "{m}%s{e}";
const char HTTP_PID_SP_FORMAT[] /PROGMEM/ = "{s}%s " "{m}%_f ";
const char HTTP_PID_PV_FORMAT[] /PROGMEM/ = "{s}%s " "{m}%
_f ";
const char HTTP_PID_POWER_FORMAT[] /PROGMEM/ = "{s}%s " "{m}%*_f " D_UNIT_PERCENT;

I've commented out the PROGMEMs and it compiled and working.

(Please, remember to close the issue when the problem has been addressed)

@sfromis
Copy link
Contributor

sfromis commented Nov 1, 2023

A compile error around those lines was fixed 15 hours ago. Did you use the very newest source?
#19890

@Jason2866
Copy link
Collaborator

Closing since none of the Infos asked in the Template is filled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants