Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berry fixed parser error with upvals in closures #18902

Merged

Conversation

s-hadinger
Copy link
Collaborator

Description:

Fix Berry compiler error found by @sfromis in berry-lang/berry#344

This is a rare case of wrong calculation of registers for upvals in closures.

I tested re-solidifying all Tasmota code, no changes.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.10
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger s-hadinger merged commit 1e74580 into arendst:development Jun 18, 2023
@s-hadinger s-hadinger deleted the berry_fix_closures_upvals branch January 6, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant