Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds driver for TC74 #18042

Closed
wants to merge 1 commit into from
Closed

Adds driver for TC74 #18042

wants to merge 1 commit into from

Conversation

mloftis
Copy link

@mloftis mloftis commented Feb 24, 2023 •
edited
Loading

Description:

Adds a driver for the TC74 I2C temperature sensor.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.2.0.7
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@mloftis
Copy link
Author

mloftis commented Feb 24, 2023

Not that while I did stuff in ifdef's for Domoticz and KNX, they are untested, cribbed from the DS18x20 support.

@arendst arendst added the on hold by dev team Result - Feature request put on hold by member of development team label Feb 25, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Action - Issue left behind - Used by the BOT to call for attention label Mar 22, 2023
@arendst
Copy link
Owner

arendst commented Mar 22, 2023

Bump

@github-actions github-actions bot removed the stale Action - Issue left behind - Used by the BOT to call for attention label Mar 22, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it hasn't any activity in last few weeks. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Action - Issue left behind - Used by the BOT to call for attention label Apr 16, 2023
@mloftis
Copy link
Author

mloftis commented Apr 16, 2023

Bump

@github-actions github-actions bot removed the stale Action - Issue left behind - Used by the BOT to call for attention label Apr 16, 2023
@jeroenst
Copy link
Contributor

jeroenst commented May 1, 2023 •
edited
Loading

@arendst what must be done in order for this pull request to be merged? Can I help?

@arendst
Copy link
Owner

arendst commented May 1, 2023

It needs some basic changes. I'll do it now.

@jeroenst
Copy link
Contributor

jeroenst commented May 1, 2023

@arendst nice, Can I help with any other open PR?

@mloftis
Copy link
Author

mloftis commented May 1, 2023

I'm also still watching. Let me know if there's anything I can do @arendst

arendst added a commit that referenced this pull request May 1, 2023
@arendst
Add support for TC74
cda2bf1 
Add support for TC74 temperature sensor by Michael Loftis (#18042)
@arendst
Copy link
Owner

arendst commented May 1, 2023

Merged just now with some changes.

@arendst arendst closed this May 1, 2023
@jeroenst
Copy link
Contributor

jeroenst commented May 1, 2023

Thanx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on hold by dev team Result - Feature request put on hold by member of development team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mloftis @arendst @jeroenst