Fix 1-pin ultrasonic sensor detection #17966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilias Daradimos <[email protected]>
barbudor
reviewed
Feb 17, 2023
| @@ -124,7 +124,7 @@ void Sr04TModeDetect(void) { | |||
| if (PinUsed(GPIO_SR04_TRIG)) { | |||
| SR04.type = (Sr04TMiddleValue(Sr04TMode3Distance(), Sr04TMode3Distance(), Sr04TMode3Distance()) != 0) ? SR04_MODE_SER_TRANSCEIVER : SR04_MODE_TRIGGER_ECHO; | |||
| } else { | |||
| SR04.type = SR04_MODE_SER_RECEIVER; | |||
| SR04.type = SR04.type = (Sr04TMiddleValue(Sr04TMode2Distance(), Sr04TMode2Distance(), Sr04TMode2Distance()) != 0) ? SR04_MODE_SER_RECEIVER : SR04_MODE_TRIGGER_ECHO; | |||
There was a problem hiding this comment.
It looks like you are repeating SR04.type = twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When 1 pin ultrasonic ranger is selected by selecting only Echo pin and this pin is a UART capable pin, sensor type is set as Serial TX only without testing whether it provides actual serial data.
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass