Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sugar Valley Neopool driver #12171

Merged
merged 1 commit into from
May 23, 2021

Conversation

curzon01
Copy link
Contributor

Description:

Add NPLight TOGGLE cmnd
Add NPFiltrationMode string parameter
Add filtration speed on result
Add undocumented register function
Fix NPLight get status
Fix hydrolysis status
Fix NPFiltration side effects
Fix pH warning
Fix hydrolysis/redox value
Fix register desc

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with core ESP32 V.1.0.6
  • I accept the CLA.

Add NPLight TOGGLE cmnd
Add NPFiltrationMode string parameter
Add filtration speed on result
Add undocumented register function
Fix NPLight get status
Fix hydrolysis status
Fix NPFiltration side effects
Fix pH warning
Fix hydrolysis/redox value
Fix register desc
@arendst arendst merged commit 1e2d4d9 into arendst:development May 23, 2021
@curzon01 curzon01 deleted the development-neopool branch May 24, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants