Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for MAX7219 Seven-Segment Display #11387

Merged
merged 8 commits into from
Mar 20, 2021
Merged

Added support for MAX7219 Seven-Segment Display #11387

merged 8 commits into from
Mar 20, 2021

Conversation

ajithvasudevan
Copy link

@ajithvasudevan ajithvasudevan commented Mar 19, 2021

Description:

This is a new Display driver which adds support for the MAX7219 seven-segment display
This adds support for the MAX7219 seven-segment display module to the existing TM163x driver ( #11031 )

Related issue (if applicable): NA

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works on Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with core ESP32 V.1.0.5
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst
Copy link
Owner

arendst commented Mar 19, 2021

Without diving too deep in I see a lot of redundancy with TM163x driver.

Perhaps it is better indeed to incorporate this driver in the TM163x code.

While doing this pay attention to the removed command DisplayBrightness 1..8 which has been replaced by the already present command DisplayDimmer 0..100.

@ajithvasudevan
Copy link
Author

Without diving too deep in I see a lot of redundancy with TM163x driver.

Perhaps it is better indeed to incorporate this driver in the TM163x code.

While doing this pay attention to the removed command DisplayBrightness 1..8 which has been replaced by the already present command DisplayDimmer 0..100.

Alright. Will do.

@ajithvasudevan
Copy link
Author

Without diving too deep in I see a lot of redundancy with TM163x driver.
Perhaps it is better indeed to incorporate this driver in the TM163x code.
While doing this pay attention to the removed command DisplayBrightness 1..8 which has been replaced by the already present command DisplayDimmer 0..100.

Alright. Will do.

@arendst ,

The current development branch changes for the TM1637/8 driver seems to have broken it.

I find that none of the commands DisplayClock, DisplayText, DisplayNumber, DisplayFloat, etc., are working for the TM1637 or TM1638.

Looking into it ...

@arendst
Copy link
Owner

arendst commented Mar 19, 2021

They only work if you select DisplayMode 0 first.

@arendst
Copy link
Owner

arendst commented Mar 19, 2021

And make sure Power 1

@arendst
Copy link
Owner

arendst commented Mar 19, 2021

And DisplayDimmer 50 ;-)

@ajithvasudevan
Copy link
Author

And DisplayDimmer 50 ;-)

DisplayDimmer default value was the issue! I was counting on it being set to a sane default as I did earlier :)

@ajithvasudevan
Copy link
Author

@arendst ,
Its done. I've moved the MAX7219 code to xdsp_15_tm1637.ino and deleted xdsp_16_max7219.ino
Tested the Display build on all 3 displays - TM1637, TM1638 and MAX7219.
DisplayModes 1,2,3 work great. Thanks for that. I'd have done it anyways ... ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants