Added XPT2046 touch screen digitizer for ILI9341 display #11159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change extends Tasmota functionality with LoLin TFT 2.4" touch screen display. The LoLin TFT 2.4" is Wemos D1 R2 mini add-on hat with TFT driver ILI9341 and restive touch screen driver XPT2046. Note: this is my first contribution, please accept my apology if not all code is as expected. |
|
What is the use for the file xpt.patch? |
|
That's my mistake, the file should not have been committed. I can try to remove ... Sorry. |
|
I have removed the unnecessary xpt.patch (my temp) file. |
arendst
reviewed
Mar 1, 2021
| @@ -152,6 +152,9 @@ enum UserSelectablePins { | |||
| GPIO_TM1637CLK, GPIO_TM1637DIO, // TM1637 interface | |||
| GPIO_PROJECTOR_CTRL_TX, GPIO_PROJECTOR_CTRL_RX, // LCD/DLP Projector Serial Control | |||
| GPIO_SSD1351_DC, | |||
| #ifdef USE_XPT2046 | |||
| GPIO_XPT2046_CS, // XPT2046 SPI Chip Select | |||
| #endif | |||
| GPIO_SENSOR_END }; | |||
There was a problem hiding this comment.
Do not use #ifdef USE_XPT2046 here as it needs to be compiled in always to keep the list complete.
So pls remove these (only here).
There was a problem hiding this comment.
Done, ifdefs removed and committed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass