-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New protobuf versionning scheme such as 21.1 is not supported #33
Comments
New version scheme is no longer using semver. Refs: |
Am I reading correctly that there's effectively no way to get I've tried lots of different permutations on the version, and either get |
Can this issue get some love? |
@per1234 any update? 🌹 |
I looked into this a little, and I think there are two reasonable approaches:
(2) is probably more correct, but I think either would work. I'll take a stab at this in a little bit. |
Opened #58 with my attempted fix. I've only tested it with the new-style versions so far, but it works correctly for me. |
Released in https://github.com/arduino/setup-protoc/releases/tag/v2.0.0 |
Describe the problem
Protobuf has recently changed its versioning scheme. The release after 3.20 is named 21.0.
To reproduce
Sample workflow:
Expected behavior
protoc --version
shows 3.21.1'arduino/setup-protoc' version
v1
Additional context
No response
Issue checklist
The text was updated successfully, but these errors were encountered: