put Linux build files inside a folder before zipping #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstasi
approved these changes
Feb 28, 2022
|
@per1234 can you test if appImage is still working on linux? I' not 100% sure the appImage will do NOT check the zip sha as well |
per1234
added
os: linux
per1234
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
The "Linux_X86-64_zip" build artifact has the perfect structure (files in a folder instead of in the root of the .zip).
As requested, I did a test of the IDE auto-update behavior after this change. I produced the following channel file to allow me to test this build as the update target in addition to testing it as the update base:
version: 99.0.1
files:
- url: arduino-ide_2.0.0-rc4-snapshot-85f5d6f_Linux_64bit.AppImage
sha512: 1YE6Y5/MegOgE9NlrO/PrPACPMrpC/5cuVJUOgY8xsYn+KcFpVNYtqKldMVPUEJKkEw1aBvlaPp0BzFeo4rYQg==
size: 246645528
blockMapSize: 258989
path: arduino-ide_2.0.0-rc4-snapshot-85f5d6f_Linux_64bit.AppImage
sha512: 1YE6Y5/MegOgE9NlrO/PrPACPMrpC/5cuVJUOgY8xsYn+KcFpVNYtqKldMVPUEJKkEw1aBvlaPp0BzFeo4rYQg==
releaseDate: 2022-02-28T03:10:27.201ZIt worked perfectly.
Thanks Alberto!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When you download the Arduino IDE in zip format for Linux and extract it, a lot of the files will be extracted in that folder. If a user does that in the Downloads folder, they will find it overflooded with files.
Change description
Reintroduce a function in the packager script to add a folder on top of the zip build, but only when on Linux.
Reviewer checklist