Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The monitor <input> is not readOnly when there is no connection to the monitor #1984

Closed
3 tasks done
kittaakos opened this issue Mar 30, 2023 · 0 comments · Fixed by #1965
Closed
3 tasks done

The monitor <input> is not readOnly when there is no connection to the monitor #1984

kittaakos opened this issue Mar 30, 2023 · 0 comments · Fixed by #1965
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

Describe the problem

I can edit the <input> when there is no connection to the monitor.

To reproduce

  • You have no boards connected to your machine,
  • Open the monitor widget (see the yellow-orange Not connected. Select a board and a port to connect automatically. message),
  • Type something into the <input>,
  • You can.
monitor_input_is_not_readonly.mp4

Expected behavior

The <input> is readOnly when there is no connection to the monitor.

Arduino IDE version

2.0.4

Operating system

macOS

Operating system version

12.6.3

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added type: imperfection Perceived defect in any part of project topic: serial monitor Related to the Serial Monitor labels Mar 30, 2023
@kittaakos kittaakos changed the title The serial monitor <input> is not readOnly when there is no connection to the monitor The monitor <input> is not readOnly when there is no connection to the monitor Mar 30, 2023
@kittaakos kittaakos added the topic: code Related to content of the project itself label Mar 30, 2023
@kittaakos kittaakos mentioned this issue Mar 30, 2023
Merged
4 tasks
kittaakos pushed a commit that referenced this issue Mar 30, 2023
fix: propagate monitor errors to the frontend
a0a3bf4 
 - Handle when the board's platform is not installed (Closes #1974)
 - UX: Smoother monitor widget reset (Closes #1985)
 - Fixed monitor <input> readOnly state (Closes #1984)
 - Set monitor widget header color (Ref #682)

Closes #1508

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 30, 2023
fix: propagate monitor errors to the frontend
ba1d61f 
 - Handle when the board's platform is not installed (Closes #1974)
 - UX: Smoother monitor widget reset (Closes #1985)
 - Fixed monitor <input> readOnly state (Closes #1984)
 - Set monitor widget header color (Ref #682)

Closes #1508

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 31, 2023
fix: propagate monitor errors to the frontend
9b8e941 
 - Handle when the board's platform is not installed (Closes #1974)
 - UX: Smoother monitor widget reset (Closes #1985)
 - Fixed monitor <input> readOnly state (Closes #1984)
 - Set monitor widget header color (Ref #682)

Closes #1508

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Apr 13, 2023
fix: propagate monitor errors to the frontend
c43d360 
 - Handle when the board's platform is not installed (Closes #1974)
 - UX: Smoother monitor widget reset (Closes #1985)
 - Fixed monitor <input> readOnly state (Closes #1984)
 - Set monitor widget header color (Ref #682)

Closes #1508

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added the conclusion: resolved Issue was resolved label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: propagate monitor errors to the frontend arduino/arduino-ide
1 participant
@kittaakos