Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive warning in DevTools when creating a new tab: Timeout after 5000 millis. The editor has not shown up in time. #1718

Closed
3 tasks done
kittaakos opened this issue Nov 28, 2022 · 0 comments · Fixed by #1719
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

Describe the problem

There are two new warnings every time I create a new tab.

root WARN Timeout after 5000 millis. The editor has not shown up in time. URI: file:///Users/a.kitta/Documents/Arduino/debug/alma.ino

They're false positives. The bug is here:

if (!widget) {
deferred.resolve(editorWidget);
}

The condition should be inverted as commented here

// If the widget was defined, it was already opened.

To reproduce

Open IDE2, open a sketch, and a new tab. The editor opens, but there are two new warnings in the console.

Expected behavior

No warning

Arduino IDE version

fe3fbb1

Operating system

macOS

Operating system version

12.5.1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 28, 2022
@kittaakos kittaakos self-assigned this Nov 28, 2022
kittaakos pushed a commit that referenced this issue Nov 28, 2022
An already opened editor widget can resolve without waiting.

Closes #1718

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Nov 29, 2022
An already opened editor widget can resolve without waiting.

Closes #1718

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants