Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more readable color for "Output" view stderr text in the "Light (Arduino)" theme #1087

Closed
3 tasks done
per1234 opened this issue Jun 21, 2022 · 5 comments · Fixed by #1836
Closed
3 tasks done
Assignees
Labels
conclusion: resolved Issue was resolved topic: accessibility Enabling the use of the software by everyone topic: theme Related to GUI theming type: enhancement Proposed improvement

Comments

@per1234
Copy link
Contributor

per1234 commented Jun 21, 2022

Describe the request

Use a brighter red/orange color for the stderr text printed in the "Output" view when using the "Light (Arduino)" theme.

I suggest using the Arduino IDE 1.x coloration as a reference, since this has already been user tested for years with favorable opinions (with the exception of those with color blindness, for whom a specialized theme will be more suitable anyway). It is defined here:

https://github.com/arduino/Arduino/blob/43b0818f7fa8073301db1b80ac832b7b7596b828/build/shared/lib/theme/theme.txt#L32

console.error.color = #E34C00

🙂 The "Output" view will be easier and more enjoyable to read.

Describe the current behavior

During the compilation or upload operations, output from the processes may be printed to the "Output" view. In order to make it easier to differentiate the types of information conveyed there, output that was written to the standard error stream is colored differently from the output written to the standard output stream (#1064).

The color used for stderr text when the default "Light (Arduino)" Arduino IDE theme is active is a fairly dark red color.

Some years ago, this coloration in the Arduino IDE 1.x theme was changed from a brighter color to a dark red very similar to the one currently in use by Arduino IDE 2.x's "Light (Arduino)" theme (arduino/Arduino@501333a). That resulted in complaints from the users:

Until the change was reverted (arduino/Arduino@8020c0d). So I think we already have clear evidence that the current coloration in the Arduino IDE 2.x "Light (Arduino)" theme is not ideal.

Arduino IDE 2.x:

image

Arduino IDE 1.8.19:

image

🙁 This very important text is difficult and unpleasant to read.

Arduino IDE version

2.0.0-rc7-snapshot-4611381

Operating system

Windows

Operating system version

10

Additional context

See #1064 (comment) for more information on the subject.


With the exception of "Light (Theia)" (which has a white "Output" view background), the other themes use a brighter color.


Also reported at:

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@per1234 per1234 added type: enhancement Proposed improvement topic: accessibility Enabling the use of the software by everyone labels Jun 21, 2022
@per1234 per1234 added the topic: theme Related to GUI theming label Jul 4, 2022
@ObviousInRetrospect
Copy link

+1 on this ... and is there a way for users to override it in the interim? the error text is really hard to read. I looked for a theme.txt in either /Applications/Arduino IDE or ~/Library/Arduino15 and came up empty.

@per1234
Copy link
Contributor Author

per1234 commented Sep 17, 2022

@ObviousInRetrospect please ask over on the Arduino forum about customizing the Arduino IDE theme. I'm sure we'll be able to help you out over there.

https://forum.arduino.cc/c/software/arduino-ide-2-0/93

@CoolByDesign
Copy link

the output text is unreadable for me. I have to highlight the field and even then it is difficult to read.
For me this issue is serious enough that I cannot use this version.

@per1234 per1234 linked a pull request Jan 27, 2023 that will close this issue
@aoloe
Copy link

aoloe commented Jan 30, 2023

on top of the error text being unreadable, the light theme should provide a light output terminal, not a dark one.

@arduino arduino locked as resolved and limited conversation to collaborators Jan 30, 2023
@91volt
Copy link

91volt commented Feb 7, 2023

PR solving the issue:
#1836

@91volt 91volt closed this as completed Feb 7, 2023
@91volt 91volt reopened this Feb 7, 2023
@91volt 91volt removed their assignment Feb 7, 2023
@ubidefeo ubidefeo self-assigned this Feb 7, 2023
@per1234 per1234 added the conclusion: resolved Issue was resolved label Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
conclusion: resolved Issue was resolved topic: accessibility Enabling the use of the software by everyone topic: theme Related to GUI theming type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants