Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency with enum type and value merge functions #2464

Open
Tracked by #5201 ...
yaacovCR opened this issue Jan 10, 2021 · 1 comment
Open
Tracked by #5201 ...

inconsistency with enum type and value merge functions #2464

yaacovCR opened this issue Jan 10, 2021 · 1 comment

Comments

@yaacovCR
Copy link
Collaborator

https://github.com/ardatan/graphql-tools/pull/2417/files#r554290366

@gmac
Copy link
Contributor

gmac commented Oct 3, 2021

From discussion concerning merge package enum tools:

It appears that the enum type and value mergers are implemented with reversed argument order from each other. While the enum type merger assigns A -> B, the enum value merger assigns B -> A. That means you'll end up with type settings from one candidate and value settings from the other.

Simple change but would require a major version bump for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants