Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decryption flag is not set #10

Open
ScottehMax opened this issue Sep 10, 2015 · 0 comments · May be fixed by #11
Open

Decryption flag is not set #10

ScottehMax opened this issue Sep 10, 2015 · 0 comments · May be fixed by #11

Comments

@ScottehMax
Copy link

xorer currently does not change the NCCH flags to reflect whether or not the NCCH is encrypted.

The flag is correctly parsed (src/types/ncch.rs lines 39 [flags_data_format] and 52 [flag_nocrypto]), but then never read, modified or written; neither decrypt_cfa nor decrypt_cxi modify the NCCH flags.

The flag signalling that the NCCH is encrypted should be unset if decrypt_cfa or decrypt_cxi succeed. Not doing so leads to a number of issues when using it:

  1. ctrtool -y insists that the hash mismatches if -p is not given.
  2. A 3DS will be unable to use the decrypted CXI/CFA/NCSD as it will try to decrypt.
  3. NCCH-parsing tools may erroneously believe the file still needs to be decrypted.
@ghost ghost linked a pull request Sep 11, 2015 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant