Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow contentContainerCustomStyle override default paddings. #482

Merged
merged 1 commit into from
May 21, 2019
Merged

Allow contentContainerCustomStyle override default paddings. #482

merged 1 commit into from
May 21, 2019

Conversation

yamov
Copy link
Contributor

@yamov yamov commented Feb 17, 2019

Platforms affected

iOS, Android

What does this PR do?

It allows the contentContainerCustomStyle prop override the default paddings. The default paddings do not always work nicely with all designs.
The change itself is pretty trivial.

What testing has been done on this change?

Tested on Android And iOS for a simple use-case

<Carousel
  ...
  contentContainerCustomStyle={{ backgroundColor: 'red', paddingLeft: 10, paddingRight: 0 }}
/>

Tested features checklist

@bd-arc bd-arc merged commit 610e55f into meliorence:master May 21, 2019
@bd-arc
Copy link
Contributor

bd-arc commented May 21, 2019

Shipped in version 3.8.0.

@yamov yamov deleted the allow-contentContainerCustomStyle-override-default-paddings branch May 27, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants