Wrong handler recompiled when running in sandbox

[epfremmer]

When I have 2 http handlers with a common base path the first (shorter) handler is recompiled when there are changes made to the second.

Example:

Say I have the following http handlers:

• src/http/get-api-v1-users/index.ts
• src/http/get-api-v1-users-000id/index.ts

When I make a change to get-api-v1-users-000id, get-api-v1-users is recompiled instead. It looks like this line is matching the first handler because they share a common filename prefix.

Hopefully, this is helpful...

[ryanblock]

Ah, wild! Fascinating find, thank you.

[epfremmer]

No problem! I ended up patching it locally by using dirname:

diff --git a/node_modules/@architect/plugin-typescript/src/index.js b/node_modules/@architect/plugin-typescript/src/index.js
index 6520fda..ba6cc66 100644
--- a/node_modules/@architect/plugin-typescript/src/index.js
+++ b/node_modules/@architect/plugin-typescript/src/index.js
@@ -1,3 +1,4 @@
+let path = require('path');
 let {
   compileProject,
   compileHandler,
@@ -48,16 +49,16 @@ module.exports = {
       let { filename, /* event, */ inventory } = params
       if (filename.endsWith('.ts') || filename.endsWith('.tsx')) {
         let { lambdasBySrcDir, shared, views } = inventory.inv
+        let dirname = path.dirname(filename);
 
         // Second pass filter by shared dirs
-        if (filename.startsWith(shared?.src) ||
-            filename.startsWith(views?.src)) {
+        if (dirname === shared?.src || dirname === views?.src) {
           await compileProject(params)
           return
         }
 
         // Second pass filter by Lambda dir
-        let lambda = Object.values(lambdasBySrcDir).find(({ src }) => filename.startsWith(src))
+        let lambda = Object.values(lambdasBySrcDir).find(({ src }) => dirname === src)
 
         if (!lambda) { return }

but I'm still fairly new to using architect so I'm not totally confident that solution works well for all projects.