Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CypressTerminalReportPrinter.PluginOptions.includeSuccessfulHookLogs type is not optional #161

Closed
spiltcoffee opened this issue Aug 12, 2022 · 1 comment
Closed

CypressTerminalReportPrinter.PluginOptions.includeSuccessfulHookLogs type is not optional #161

spiltcoffee opened this issue Aug 12, 2022 · 1 comment
Assignees
@archfz
Labels
bug Something isn't working

Comments

@spiltcoffee
Copy link

cypress-terminal-report/src/installLogsPrinter.d.ts

Line 106 in 78dfd0f

includeSuccessfulHookLogs: boolean

Considering it's marked with a @default JSDoc annotation, and all of the other fields on the PluginOptions object are optional, it seems like this field should also be optional.
@archfz archfz added the bug Something isn't working label Aug 12, 2022
@archfz archfz self-assigned this Aug 12, 2022
@archfz
Copy link
Owner

archfz commented Aug 12, 2022

Fix released in 4.1.2

@archfz archfz closed this as completed Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archfz archfz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spiltcoffee @archfz