Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource.save() assigns permissions #11564

Closed
jacobtylerwalls opened this issue Oct 22, 2024 · 0 comments · Fixed by #11622
Closed

Resource.save() assigns permissions #11564

jacobtylerwalls opened this issue Oct 22, 2024 · 0 comments · Fixed by #11622

Comments

@jacobtylerwalls
Copy link
Member

The Resource proxy model save() method has code predating the 7.6 permissions framework that appears to do what the principal user functionality now does. If that's so, we should look into removing it to make sure we're not unnecessarily making changes to object permissions.

try:
for perm in (
"view_resourceinstance",
"change_resourceinstance",
"delete_resourceinstance",
):
assign_perm(perm, user, self)
except NotUserNorGroup:
pass

cc/ @aarongundel

@chiatt chiatt added this to pipeline Oct 22, 2024
@chiatt chiatt moved this to 🔖 Ready in pipeline Nov 12, 2024
@aarongundel aarongundel linked a pull request Nov 13, 2024 that will close this issue
11 tasks
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 👀 In Review in pipeline Nov 13, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants