Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Layer Manager can crash when using default permissions #11522

Closed
chiatt opened this issue Oct 2, 2024 · 2 comments · Fixed by #11523
Closed

Map Layer Manager can crash when using default permissions #11522

chiatt opened this issue Oct 2, 2024 · 2 comments · Fixed by #11523
Assignees
Labels
Priority: High Type: Bug Something isn't working

Comments

@chiatt
Copy link
Member

chiatt commented Oct 2, 2024

When checking permissions while loading the map layer manager, the graphid of an object is checked against the graphs in the DEFAULT_PERMISSIONS setting. If a Nodegroup is passed in, an error can occur because nodegroups do not have a graph_id attribute.

@chiatt chiatt self-assigned this Oct 2, 2024
@chiatt chiatt added this to pipeline Oct 2, 2024
@chiatt chiatt added Type: Bug Something isn't working Priority: High labels Oct 2, 2024
@chiatt chiatt mentioned this issue Oct 2, 2024
11 tasks
@chiatt chiatt closed this as completed Oct 2, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in pipeline Oct 2, 2024
@chiatt chiatt linked a pull request Oct 2, 2024 that will close this issue
11 tasks
@jacobtylerwalls
Copy link
Member

Sounds like a nice use case for #11396 :-)

@chiatt
Copy link
Member Author

chiatt commented Oct 3, 2024

Sounds like a nice use case for #11396 :-)

Nice connection - but in this case we don't actually need the graphid because default permissions don't apply to nodegroups. It might be nice to extend default permissions to nodegroups, though, in which case #11396 would be very helpful, but that would that would probably be a much bigger change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Type: Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants