Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier configuration to format vue/ts files #10575

Closed
jacobtylerwalls opened this issue Feb 1, 2024 · 0 comments · Fixed by #10737
Closed

Add prettier configuration to format vue/ts files #10575

jacobtylerwalls opened this issue Feb 1, 2024 · 0 comments · Fixed by #10737
Assignees

Comments

@jacobtylerwalls
Copy link
Member

I'd love to get a .prettierrc in place as soon as possible so we can standardize on:

  • single vs. double quotes
  • 2 vs. 4 spaces
  • line-length

And have a github action step fail PRs that haven't been formatted. Then we can socialize the knowledge about how to configure "format on save" in VS Code so that you never have to hand-format again. (Separately, I'll suggest doing the same thing with the python backend because we seem to get lots of PRs with unrelated formatting changes on a regular basis...)

I don't have a strong preference about quote or indentation width myself.

Originally posted by @jacobtylerwalls in archesproject/arches-docs#394 (comment)

@chiatt chiatt added this to pipeline Feb 1, 2024
@jacobtylerwalls jacobtylerwalls self-assigned this Apr 3, 2024
@jacobtylerwalls jacobtylerwalls moved this to 🔖 Ready in pipeline Apr 3, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In progress in Controlled List Manager Apr 3, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🔖 Ready to 🏗 In Progress in pipeline Apr 3, 2024
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 👀 In review in Controlled List Manager Apr 3, 2024
@jacobtylerwalls jacobtylerwalls linked a pull request Apr 3, 2024 that will close this issue
6 tasks
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Apr 3, 2024
@jacobtylerwalls jacobtylerwalls changed the title Add prettier configuration to auto-format vue/ts files Add prettier configuration to format vue/ts files Apr 9, 2024
jacobtylerwalls added a commit that referenced this issue Apr 26, 2024
jacobtylerwalls added a commit that referenced this issue Apr 26, 2024
jacobtylerwalls added a commit that referenced this issue Apr 26, 2024
jacobtylerwalls added a commit that referenced this issue Apr 26, 2024
jacobtylerwalls added a commit that referenced this issue May 2, 2024
Add formatting step to template CI workflow
jacobtylerwalls added a commit that referenced this issue Jun 10, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Jun 10, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Controlled List Manager Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant