feat: improve --skip-dirs and --skip-files #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
force-pushed
the
skip_files_dirs
branch
from
55c3a40 to
a39b834
Compare
masahiro331
approved these changes
Oct 1, 2021
masahiro331
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--skip-dirsand--skip-filesused to not affect actual scanning. These options just filter the result because it affects the cache if we skip those files and dirs during scanning. It didn't matter since scanning is fast enough, but Trivy recently supported JAR/WAR/EAR scanning. It requires Internet access and takes some time. It would be useful if those options actually skip scanning those files and dirs, especially in the case of Java scanning.Related issues
Close #1218
Close #1185
Close #982
Close #766
Close #665
Blockers