feat(debian): support the versions that reached EOL #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
changed the title
ankk13
approved these changes
Sep 17, 2021
| } | ||
|
|
||
| // It means unfixed vulnerability. We don't have to compare versions. | ||
| if adv.FixedVersion == "" { |
There was a problem hiding this comment.
Won't this be always the case, as Debian buckets will only have unfixed versions?
https://github.com/aquasecurity/trivy-db/blob/726b7b72a47bff2aacd01a4ea4104c5fda3255a3/pkg/vulnsrc/debian/debian.go#L405
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
* refactor(debian): aggregate oval and json api into salsa * fix(vulnerability): use package-specific severity * chore(mod): update trivy-db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Trivy used to use OVAL and JSON API for Debian scanning, but this PR migrates to Debian repository. This is because JSON API will no longer return security advisories of EOSL versions. We want to keep supporting old versions as well. This PR allows it.
PRs
Need to merge the below PRs first