Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suse): Align SUSE/OpenSUSE OS Identifiers #7965

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

josegomezr
Copy link
Contributor

@josegomezr josegomezr commented Nov 20, 2024

Description

For OpenSUSE:

  • Replace dots by dashes in OS identifier to match the value present in ID
    field of /etc/os-release

For SUSE:

  • Use the short name sles and slem instead of suse linux enterprise {micro|server} to get closer to the actual content of the ID field of
    /etc/os-release.

Related issues

Related PRs

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

- On SUSE systems the `/etc/os-release` uses short names (like: `sles`,
  `slem`) instead of a long sentence `suse linux enterprise
  {micro|server}`

Signed-off-by: Jose D. Gomez R <[email protected]>
- On OpenSUSE systems the `/etc/os-release` uses dashes instead of dots.

Signed-off-by: Jose D. Gomez R <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@josegomezr josegomezr changed the title Align SUSE/OpenSUSE OS Identifiers feat(suse): Align SUSE/OpenSUSE OS Identifiers Nov 20, 2024
@knqyf263 knqyf263 enabled auto-merge November 21, 2024 05:57
@knqyf263
Copy link
Collaborator

Thanks

@knqyf263 knqyf263 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into aquasecurity:main with commit 45d3b40 Nov 21, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aligning SUSE & OpenSUSE identifiers with /etc/os-release values
3 participants