fix(misconf): Update trivy-checks default repo to mirror.gcr.io
#7953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
requested changes
Nov 19, 2024
|
trivy-cheks is available on Docker Hub trivy conf main.tf -d --checks-bundle-repository mirror.gcr.io/aquasec/trivy-checks:latest
2024-11-19T14:03:27+06:00 DEBUG Default config file "file_path=trivy.yaml" not found, using built in values
2024-11-19T14:03:27+06:00 DEBUG Cache dir dir="/Users/nikita/Library/Caches/trivy"
2024-11-19T14:03:27+06:00 DEBUG Cache dir dir="/Users/nikita/Library/Caches/trivy"
2024-11-19T14:03:27+06:00 DEBUG Parsed severities severities=[UNKNOWN LOW MEDIUM HIGH CRITICAL]
2024-11-19T14:03:27+06:00 INFO [misconfig] Misconfiguration scanning is enabled
2024-11-19T14:03:27+06:00 DEBUG [misconfig] Failed to open the check metadata err="open /Users/nikita/Library/Caches/trivy/policy/metadata.json: no such file or directory"
2024-11-19T14:03:27+06:00 INFO [misconfig] Need to update the built-in checks
2024-11-19T14:03:27+06:00 INFO [misconfig] Downloading the built-in checks...
2024-11-19T14:03:27+06:00 DEBUG [misconfig] Loading check bundle repository="mirror.gcr.io/aquasec/trivy-checks:latest"
201.91 KiB / 201.91 KiB [------------------------------------------------------] 100.00% 2.47 MiB p/s 300ms
2024-11-19T14:03:29+06:00 DEBUG [misconfig] Digest of the built-in checks digest="sha256:adcb0056766fa124695e6d538304b6d4bbf9409eafbc0b6e1f3a8b7439f999c6"
2024-11-19T14:03:29+06:00 DEBUG [misconfig] Checks successfully loaded from disk |
knqyf263
reviewed
Nov 20, 2024
| @@ -19,7 +19,7 @@ import ( | |||
|
|
|||
| const ( | |||
| BundleVersion = 1 // Latest released MAJOR version for trivy-checks | |||
| BundleRepository = "ghcr.io/aquasecurity/trivy-checks" | |||
| BundleRepository = "mirror.gcr.io/aquasec/trivy-checks" | |||
There was a problem hiding this comment.
We also use GHCR as a secondary for other databases. Just in case mirror.gcr.io is down, Trivy falls back into GHCR.
There was a problem hiding this comment.
Apart from that, I think that the --checks-bundle-repository flag should also provide fallback functionality just like the --db-repository flag. Right now we can only specify a single checks repository with this option, it would we great if multiple checks repo can be specified using this option so that if one repo fails second one can be used as a fallback.
There was a problem hiding this comment.
Yes we should. Track #7960
simar7
changed the title
mirror.gcr.iomirror.gcr.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge once trivy-checks is available on DockerHub.
Checklist