Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(misconf): Remove unused options #7896

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(misconf): Remove unused options #7896

wants to merge 3 commits into from

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Nov 9, 2024 •
edited
Loading

Description

These options aren't often used due to reasons described in the disucussion and can be deprecated.

Related issues

Related discussion

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 self-assigned this Nov 9, 2024
@simar7 simar7 marked this pull request as ready for review November 19, 2024 04:55
@nikpivkin
Copy link
Contributor

@simar7 Does that mean we should now only support deny rules? https://github.com/aquasecurity/trivy/blob/main/pkg/iac/rego/scanner.go#L388-L395

@nikpivkin
Copy link
Contributor

combined is also mentioned in the documentation.

@simar7
Copy link
Member Author

simar7 commented Nov 20, 2024 •
edited
Loading

@simar7 Does that mean we should now only support deny rules? https://github.com/aquasecurity/trivy/blob/main/pkg/iac/rego/scanner.go#L388-L395

Yes, there's even a comment about this https://github.com/aquasecurity/trivy/blame/797b36fbad90b8e7f04e16e2cf08d6bdc0255ac7/pkg/iac/rego/scanner.go#L387

Actually I just realized we didn't issue an announcement for this change. I will prepare that first.

Discussion here: #7961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin Awaiting requested review from nikpivkin nikpivkin is a code owner

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@simar7 simar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(misconf): Remove unused options
2 participants
@simar7 @nikpivkin