feat(sbom): add vulnerability support for SPDX formats #7213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goneall Does it meet your requirements? Please feel free to point it out if we're missing something. |
Yes - that meets the requirements. Thanks! |
knqyf263
reviewed
Jul 25, 2024
pkg/sbom/spdx/marshal.go
Outdated
| @@ -184,6 +193,9 @@ func (m *Marshaler) Marshal(ctx context.Context, bom *core.BOM) (*spdx.Document, | |||
| relationShips = append(relationShips, m.spdxRelationShip(refA, refB, m.spdxRelationshipType(rel.Type))) | |||
| } | |||
| } | |||
|
|
|||
| bom.Vulnerabilities() | |||
There was a problem hiding this comment.
hmm... Maybe I was checking something and forgot to delete it.
Thanks. Removed in b1ca52e
knqyf263
approved these changes
Jul 25, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SPDX v2.3 uses
externalRefsfor advisories (spdx-example).See #6308 for more details
example:
➜ trivy -d image -f spdx-json -o report.spdx.json ubuntu --scanners vuln ... { "name": "libssl3t64", "SPDXID": "SPDXRef-Package-ed46e6c8dd5adb2d", "versionInfo": "3.0.13-0ubuntu3.1", "supplier": "Organization: Ubuntu Developers \[email protected]\u003e", "downloadLocation": "NONE", "filesAnalyzed": false, "sourceInfo": "built package from: openssl 3.0.13-0ubuntu3.1", "licenseConcluded": "Apache-2.0 AND Artistic AND GPL-1.0-only", "licenseDeclared": "Apache-2.0 AND Artistic AND GPL-1.0-only", "externalRefs": [ { "referenceCategory": "PACKAGE-MANAGER", "referenceType": "purl", "referenceLocator": "pkg:deb/ubuntu/[email protected]?arch=amd64\u0026distro=ubuntu-24.04" }, { "referenceCategory": "SECURITY", "referenceType": "advisory", "referenceLocator": "https://avd.aquasec.com/nvd/cve-2024-2511" }, { "referenceCategory": "SECURITY", "referenceType": "advisory", "referenceLocator": "https://avd.aquasec.com/nvd/cve-2024-4603" }, { "referenceCategory": "SECURITY", "referenceType": "advisory", "referenceLocator": "https://avd.aquasec.com/nvd/cve-2024-4741" } ], "attributionTexts": [ "LayerDiffID: sha256:a30a5965a4f7d9d5ff76a46eb8939f58e95be844de1ac4a4b452d5d31158fdea", "LayerDigest: sha256:9c704ecd0c694c4cbdd85e589ac8d1fc3fd8f890b7f3731769a5b169eb495809", "PkgID: [email protected]", "PkgType: ubuntu" ], "primaryPackagePurpose": "LIBRARY" }, ...Related issues
Checklist