Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): use go-mvn-version to remove Package duplicates #7088

Merged

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Jul 3, 2024

Description

We remove duplicates of packages.
But there are cases when Packages uses same version, but one of package omits 0 patch version (e.g. 2.17.0 and 2.17).

Using go-mvn-version to compare version solves this problem.

before:

➜ trivy -q image apachepulsar/pulsar:3.3.0 --format cyclonedx | grep '"purl": "pkg:maven/org.glassfish.jersey.containers/jersey-container-servlet-core'
      "purl": "pkg:maven/org.glassfish.jersey.containers/[email protected]",
      "purl": "pkg:maven/org.glassfish.jersey.containers/[email protected]",

after:

➜ trivy -q image apachepulsar/pulsar:3.3.0 --format cyclonedx | grep '"purl": "pkg:maven/org.glassfish.jersey.containers/jersey-container-servlet-core'
      "purl": "pkg:maven/org.glassfish.jersey.containers/[email protected]",

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jul 3, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review July 3, 2024 09:42
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner July 3, 2024 09:42
@knqyf263 knqyf263 added this pull request to the merge queue Jul 4, 2024
Merged via the queue into aquasecurity:main with commit a7a304d Jul 4, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Jul 4, 2024
@DmitriyLewen DmitriyLewen deleted the fix-java/use-comparator-for-versions branch July 8, 2024 04:34
skahn007gl pushed a commit to skahn007gl/trivy that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants