Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log.FilePath() function for logger #7080

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

We often use log.String() with file/filepath/path/etc. key for filepath.
Add log.FilePath() function to use a consistent key name.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was inconsistent, like file_path, file, path, etc. I'm happy with this change 👍

@knqyf263 knqyf263 added this pull request to the merge queue Jul 2, 2024
Merged via the queue into aquasecurity:main with commit 1f5f348 Jul 2, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Jul 2, 2024
skahn007gl pushed a commit to skahn007gl/trivy that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants