feat!: add clean subcommand

[knqyf263]

Description

Delete cache management flags and add trivy clean.

Clear all caches

Before

$ trivy image --reset

After

$ trivy clean --all

Clear scan cache

Before

$ trivy image --clear-cache

After

$ trivy clean --scan-cache

Clear checks bundle

Before

$ trivy config --reset-checks-bundle

After

$ trivy clean --checks-bundle

Clear vulnerability database

Before

N/A (trivy image --reset removes all)

After

$ trivy clean --vuln-db

Clear Java database

Before

N/A (trivy image --reset removes all)

After

$ trivy clean --java-db

Related issues

• Close Introduce trivy clean command and remove cache-clearing flags #6992

Checklist

• I've read the guidelines for contributing to this repository.
• I've followed the conventions in the PR title.
• I've added tests that prove my fix is effective or that my feature works.
• I've updated the documentation with the relevant information (if needed).
• I've added usage information (if the PR introduces new options)
• I've included a "before" and "after" example to the description (if the PR is a user interface change).

[DmitriyLewen]

@knqyf263 i found that we show 2 same errors:

➜  ./trivy -d image --reset alpine
2024-06-24T11:18:41+06:00       ERROR   "--reset" was removed. Use "trivy clean --all" instead.
2024-06-24T11:18:41+06:00       FATAL   Fatal error     flag error: db flag error: unable to parse flag: "--reset" was removed

[knqyf263]

2024-06-24T11:18:41+06:00 ERROR "--reset" was removed. Use "trivy clean --all" instead.
2024-06-24T11:18:41+06:00 FATAL Fatal error flag error: db flag error: unable to parse flag: "--reset" was removed

I returned Use "trivy clean --all" instead as an error, but it appears at the end of the log message and is therefore difficult to find as below.

2024-06-24T11:18:41+06:00 FATAL Fatal error flag error: db flag error: unable to parse flag: "--reset" was removed.
use "trivy clean --all" instead.

I eventually separated the error message. In short, it's intended.

If you don't like "--reset" was removed. is displayed twice, I can change the error message.

[DmitriyLewen]

I eventually separated the error message. In short, it's intended.

Got it 😄
Then no problem 👍

[knqyf263]

@DmitriyLewen I change the message slightly.
5a989d4

[knqyf263]

@simar7 @nikpivkin According to the discussion in #6992, I didn't add --terraform-module flag. If you want to move the cache under the Trivy cache directory and let Trivy delete the cache, please feel free to open a new PR. I don't think it's a blocker of this PR.

[DmitriyLewen]

@knqyf263
I understand that didn't write about comments for --reset-checks-bundle flag.
Added in 8995644

[knqyf263]

@DmitriyLewen Thanks! It's my bad.

[knqyf263]

@chen-keinan @simar7 @nikpivkin Since it's a breaking change, I'd wait for you guys.

[nikpivkin]

LGTM!

[knqyf263]

Announced #7010

[simar7]

I didn't know but we seemed to have supported TRIVY_RESET as an environment variable to clean the cache in the past. This came up now because some users used to use this environment variable in their CI runs to clean the cache prior to running trivy-action. See this for an example.

It seems at some point, we have dropped support for this environment variable (and maybe other TRIVY_* envvars?) but I wasn't able to find that change.

In any case, if we no longer support that environment variable, we have to implement a way in trivy-action to be able to support such a use case. Please correct me if I missed something.

[knqyf263]

TRIVY_RESET was removed, but envs for new flags are still supported.

$ TRIVY_ALL=true trivy clean
2024-07-11T11:47:57+04:00       INFO    Removing all caches...

$ TRIVY_SCAN_CACHE=true trivy clean
2024-07-11T11:48:32+04:00       INFO    Removing scan cache...

[simar7]

@knqyf263 OK looks like in that case we will need to add support for this in the action as currently I don't see anyway to clean the cache from the action.