Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secret): Asymmetric Private Key shouldn't start with space #6867

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Jun 6, 2024

Description

There are times when Asymmetric Private Key example uses space.
e.g. https://github.com/googleapis/google-api-python-client/blob/a999ad0d152d6404d379c8332bc27abfe85ba7d7/googleapiclient/discovery_cache/documents/appengine.v1.json#L2088
To avoid these cases Asymmetric Private Key shouldn't start with space.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jun 6, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review June 7, 2024 02:44
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner June 7, 2024 02:44
@knqyf263 knqyf263 added this pull request to the merge queue Jun 7, 2024
Merged via the queue into aquasecurity:main with commit bb26445 Jun 7, 2024
14 checks passed
@aqua-bot aqua-bot mentioned this pull request Jun 6, 2024
@DmitriyLewen DmitriyLewen deleted the fix-secret/asymmetric-private-key-as-space branch June 10, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants