Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): compare pkg names from poetry.lock and pyproject.toml in lowercase #6852

Conversation

DmitriyLewen
Copy link
Contributor

Description

There are cases where package names from poetry.lock and pyproject.toml use different case.
e.g. pyproject.toml uses Flask, but poetry.lock uses flask
So we need to compare lowercase package names.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jun 4, 2024
@DmitriyLewen DmitriyLewen changed the title fix(poetry): compare pkg names from poetry.lock and pyproject.toml in lowercase fix(python): compare pkg names from poetry.lock and pyproject.toml in lowercase Jun 4, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review June 4, 2024 11:05
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner June 4, 2024 11:05
@DmitriyLewen DmitriyLewen marked this pull request as draft June 4, 2024 11:11
@DmitriyLewen DmitriyLewen marked this pull request as ready for review June 5, 2024 04:46
@knqyf263 knqyf263 added this pull request to the merge queue Jun 5, 2024
Merged via the queue into aquasecurity:main with commit faa9d92 Jun 5, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Jun 5, 2024
@knqyf263
Copy link
Collaborator

knqyf263 commented Jun 7, 2024

@aqua-bot backport release/v0.52

@aqua-bot
Copy link
Contributor

aqua-bot commented Jun 7, 2024

Backport PR created: #6878

@DmitriyLewen DmitriyLewen deleted the fix-poetry/case-insensitive-package-names branch June 10, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(poetry): handle package names in a case-insensitive manner
3 participants