Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(misconf): add Terraform 'removed' block to schema #6640

Merged
merged 1 commit into from
May 7, 2024
Merged

feat(misconf): add Terraform 'removed' block to schema #6640

merged 1 commit into from
May 7, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented May 6, 2024 •
edited
Loading

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin changed the title feat(misconf): add support for Terraform 'removed' block feat(misconf): add Terraform 'removed' block to schema May 6, 2024
@nikpivkin nikpivkin marked this pull request as ready for review May 7, 2024 06:26
@nikpivkin nikpivkin requested a review from simar7 as a code owner May 7, 2024 06:26
simar7
simar7 reviewed May 7, 2024
View reviewed changes
pkg/iac/terraform/schema.go
Comment on lines +51 to +53
{
Type: "removed",
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to find this list of hcl.BlockHeaderSchema types in the hcl repo but had no luck. I assume it doesn't exist or else we could just import it? Updating this each time would mean running into this problem again when a new block gets added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here. We can't import this as the terraform code is in the internal package.

@simar7 simar7 self-requested a review May 7, 2024 19:58
@simar7 simar7 added this pull request to the merge queue May 7, 2024
Merged via the queue into aquasecurity:main with commit b7a0a13 May 7, 2024
16 checks passed
@nikpivkin nikpivkin deleted the tf-removed branch May 8, 2024 03:03
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(misconf): add Terraform 'removed' block to schema
2 participants
@nikpivkin @simar7