Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use --vuln-type flag for Packages #6269

Closed
DmitriyLewen opened this issue Mar 5, 2024 Discussed in #6225 · 3 comments · Fixed by #7104
Closed

use --vuln-type flag for Packages #6269

DmitriyLewen opened this issue Mar 5, 2024 Discussed in #6225 · 3 comments · Fixed by #7104
Assignees
@DmitriyLewen
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@DmitriyLewen
Copy link
Contributor

Description

--vuln-type flag was added in v0.0.1 even before SBOM. It makes sense to add support for packages.

Discussed in #6225
@DmitriyLewen DmitriyLewen added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 5, 2024
@DmitriyLewen
Copy link
Contributor Author

🎉 🎉 🎉 v0.52.0 already support this (after #6765) 🎉 🎉 🎉 :

➜ trivy -q image aquasec/trivy --vuln-type os,library -f json --list-all-pkgs | grep '"Class":'
      "Class": "os-pkgs",
      "Class": "lang-pkgs",

➜ trivy -q image aquasec/trivy --vuln-type os -f json --list-all-pkgs | grep '"Class":'
      "Class": "os-pkgs",

➜ trivy -q image aquasec/trivy --vuln-type library -f json --list-all-pkgs | grep '"Class":'
      "Class": "lang-pkgs",

@DmitriyLewen
Copy link
Contributor Author

since this flag now works for Packages - maybe we should change its name to --pkg-type.
@knqyf263 wdyt?

@knqyf263
Copy link
Collaborator

knqyf263 commented Jul 4, 2024

since this flag now works for Packages - maybe we should change its name to --pkg-type. @knqyf263 wdyt?

It makes sense.

@DmitriyLewen DmitriyLewen mentioned this issue Jul 5, 2024
Merged
6 tasks
@DmitriyLewen DmitriyLewen self-assigned this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriyLewen DmitriyLewen

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): rename --vuln-type flag to --pkg-types flag DmitriyLewen/trivy
2 participants
@knqyf263 @DmitriyLewen