chore(misconf): Simplify nomenclature for misconfig checks

[simar7]

Today we have a variety of terms to refer to a check, namely:

1. Policy
2. Check
3. Rule

All refer to the same concept of checking for a misconfiguration. We can simplify this and rename everything as a check.

This will require an update to both the docs and the code. This applies to both Go and Rego.

[itaysk]

for reference: #3620

[knqyf263]

Sounds good. For example, will the policy bundle renamed to the check bundle?

[simar7]

Sounds good. For example, will the policy bundle renamed to the check bundle?

Sounds reasonable. After all it is a bundle of checks 😄

[itaysk]

policy is overloaded. rule is not accurate for our use case. check sounds ok to me. but i'm ok with any name we choose as long as it's consistent.

[knqyf263]

i'm ok with any name we choose as long as it's consistent.

Same here. We just need consistency.

[simar7]

Just an update on this: Most of the work is done to be able to do this restructuring, the last step being renaming the trivy-policies repo to trivy-checks.

We'll do that in the next release of Trivy as renaming a repo can have other consequences (redirection, GHCR bundle etc.) which we need to get right. So it's better to have in the next release of Trivy.

[nikpivkin]

@simar7 The documentation, cli flags and code still use the term policy. Will this be updated?

[simar7]

@simar7 The documentation, cli flags and code still use the term policy. Will this be updated?

That's right. Once we have the trivy-polcies repo renamed to trivy-checks, we can start using it in Trivy and all it's parts (docs, flags, etc.)