-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(php): add installed.json file support #4865
feat(php): add installed.json file support #4865
Conversation
This PR is stale because it has been labeled with inactivity. |
This PR is stale because it has been labeled with inactivity. |
This PR is stale because it has been labeled with inactivity. |
This PR is stale because it has been labeled with inactivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be late
pkg/fanal/analyzer/const.go
Outdated
@@ -49,7 +49,8 @@ const ( | |||
TypeCargo Type = "cargo" | |||
|
|||
// PHP | |||
TypeComposer Type = "composer" | |||
TypeComposer Type = "composer" | |||
TypeComposerInstalled Type = "composer-installed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about composer-vendor
?
TypeComposerInstalled Type = "composer-installed" | |
TypeComposerInstalled Type = "composer-vendor" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intalled.json
file placed in path_to_app/vendor/...
dir.
So it make sense.
Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file should be located under php/composer
as installed.json
is a composer-specific file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved
Description
Add
installed.json
file support.Supported modes -
image
androotfs
.Scanning
composer.lock
files is only possible infs
andrepo
modes nowExample of work:
Related Issues:
Checklist