perf(dpkg): emptyLineSplit allocates causing some unnecessary memory allocation in this scanner

[paulcacheux]

Description

The function emptyLineSplit used to split files into empty line separated groups of key: value lines allocates and this can cause some unnecessary memory allocation. This was discovered through profiling of some code calling trivy.

Desired Behavior

This function should not allocate

Actual Behavior

This function allocates by doing some bytes to string conversion in

strings.Index(string(data), "\n\n")

Reproduction Steps

1. use the dpkg scanner

Target

Filesystem

Scanner

Vulnerability

Output Format

None

Mode

None

Debug Output

N/A

Operating System

debian based linux

Version

N/A

Checklist

• Run trivy clean --all
• Read the troubleshooting

[paulcacheux]

fixed by #7065