From 85dadf56265647c000191561db10b08a4948c140 Mon Sep 17 00:00:00 2001
From: Nikita Pivkin <nikita.pivkin@smartforce.io>
Date: Tue, 6 Aug 2024 11:13:28 +0700
Subject: [PATCH] perf(misconf): do not convert contents of a YAML file to
 string (#7292)

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
---
 pkg/iac/detection/detect.go            | 10 +++++-----
 pkg/iac/scanners/yaml/parser/parser.go | 11 +++++------
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/pkg/iac/detection/detect.go b/pkg/iac/detection/detect.go
index 787b82cb0b6a..6a7eb1f8ca3d 100644
--- a/pkg/iac/detection/detect.go
+++ b/pkg/iac/detection/detect.go
@@ -221,15 +221,15 @@ func init() {
 		}
 		data := buf.Bytes()
 
-		marker := "\n---\n"
-		altMarker := "\r\n---\r\n"
-		if bytes.Contains(data, []byte(altMarker)) {
+		marker := []byte("\n---\n")
+		altMarker := []byte("\r\n---\r\n")
+		if bytes.Contains(data, altMarker) {
 			marker = altMarker
 		}
 
-		for _, partial := range strings.Split(string(data), marker) {
+		for _, partial := range bytes.Split(data, marker) {
 			var result map[string]any
-			if err := yaml.Unmarshal([]byte(partial), &result); err != nil {
+			if err := yaml.Unmarshal(partial, &result); err != nil {
 				continue
 			}
 			match := true
diff --git a/pkg/iac/scanners/yaml/parser/parser.go b/pkg/iac/scanners/yaml/parser/parser.go
index d8b50faf2437..febcfb100008 100644
--- a/pkg/iac/scanners/yaml/parser/parser.go
+++ b/pkg/iac/scanners/yaml/parser/parser.go
@@ -6,7 +6,6 @@ import (
 	"io"
 	"io/fs"
 	"path/filepath"
-	"strings"
 
 	"gopkg.in/yaml.v3"
 
@@ -77,15 +76,15 @@ func (p *Parser) ParseFile(_ context.Context, fsys fs.FS, path string) ([]any, e
 
 	var results []any
 
-	marker := "\n---\n"
-	altMarker := "\r\n---\r\n"
-	if bytes.Contains(contents, []byte(altMarker)) {
+	marker := []byte("\n---\n")
+	altMarker := []byte("\r\n---\r\n")
+	if bytes.Contains(contents, altMarker) {
 		marker = altMarker
 	}
 
-	for _, partial := range strings.Split(string(contents), marker) {
+	for _, partial := range bytes.Split(contents, marker) {
 		var target any
-		if err := yaml.Unmarshal([]byte(partial), &target); err != nil {
+		if err := yaml.Unmarshal(partial, &target); err != nil {
 			return nil, err
 		}
 		results = append(results, target)