Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose detail info for config audit report as Prometheus metrics #1148

Closed
Tracked by #1310
, #1332
...
JKnino opened this issue Apr 4, 2023 · 3 comments · Fixed by #1302
Closed
Tracked by #1310
, #1332
...

Expose detail info for config audit report as Prometheus metrics #1148

JKnino opened this issue Apr 4, 2023 · 3 comments · Fixed by #1302
Assignees
@geoffrey1330
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning

Comments

@JKnino
Copy link

JKnino commented Apr 4, 2023

is it possible to get configAudit ID (KSV) in Prometheus, would like to have them in grafana, thank you
@JKnino JKnino added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 4, 2023
@chen-keinan chen-keinan added priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning labels Apr 5, 2023
@JKnino
Copy link
Author

JKnino commented Apr 5, 2023

actually you have made great work with vulnerabilityID/VulnerabilityReport exposing all need Infos which help us to create more detailed grafana panels/dashboards , it would just make sense to do that in same way for all other segments as:

ConfigAuditReport
RbacAssessmentReport
InfraAssessmentReport
ClusterComplianceReport

since having just number and status does not tell to much and we need to use lens or look to k8 directly

@JKnino JKnino changed the title FEATURE REQUEST Get configAudit ID in Prometheus FEATURE REQUEST Detailed Metrics for all Reports in Prometheus Apr 5, 2023
@AP-XD
Copy link
Contributor

AP-XD commented Apr 7, 2023 •
edited
Loading

I have also mentioned about the same thing in #1121 . Being able to access the ClusterComplianceReport in the metrics endpoint would be very helpful! For now I am using a custom REST API to serve the json in https://www.npoint.io/ and then using it via JSON API plugin in Grafana dashboard.

@chen-keinan chen-keinan added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 8, 2023
@geoffrey1330
Copy link
Contributor

Hi @chen-keinan could you assign this issue to me.

This was referenced Jun 15, 2023
Merged
Closed
@chen-keinan chen-keinan changed the title FEATURE REQUEST Detailed Metrics for all Reports in Prometheus Expose detail info for config audit report as Prometheus metrics Jun 18, 2023
@geoffrey1330 geoffrey1330 mentioned this issue Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffrey1330 geoffrey1330

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add detail configaudit info as prometheus metric geoffrey1330/trivy-operator
4 participants
@chen-keinan @geoffrey1330 @AP-XD @JKnino