-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MPTCP support #2068
Comments
Hello @cdelzotti, we're changing the way we capture network packages/events in tracee (very soon) and I believe we won't need to deal with physical layer details such as bonding/mptcp. I'll have this opened to make sure and close it once we get the code merged. |
Hm, what do you mean by physical layer details ? From what I understood Multipath TCP is now implemented within the Linux Kernel to provide MPTCP directly from network edges, isn't it ? |
@cdelzotti Sorry, I mixed concepts (bonding/ether-channel) with MPTCP (multiple flows/windows same socket). We're current replacing our network/capturing code and things will be more clear once we have finished it. By a quick read of THIS and THIS, I would say, as long as the different TCP flows contexts are obtainable from the places we're tracing (eBPF program attachpoints), I would be okay as long as we had a very good usecase for it.
Still, lets wait for the new netcode to be merged (0.9.0 release) and then we can check if this is something we want to do (and discuss how if it is). |
For the usecase matter, they're currently implementing MPTCP within basic tools such as curl or openssh : https://github.com/mptcp-apps . And iperf might have MPTCP support some day (Even if this PR seems to be hanging there for a while now) : esnet/iperf#1166 . But anyway, as it seems that MPTCP can be used with a simple socket configuration (https://lwn.net/Articles/791376/), I thought it might be relevant to have Tracee parsing MPTCP metadata too. |
Prerequisites
Select one OR another:
Feature description
When tracing
net_packet
events, Tracee already parses a bunch of metadata (IP source/destination, TCP ports, etc). I thought Tracee could also parse Multipath TCP information (DSS, Data Sequence, etc) as MPTCP is a part of the Linux Kernel since version 5.6.If you think it's a good idea, I can take care of the implementation.
Additional Information (feature drawings, files, logs, etc)
For further details about MPTCP : https://www.rfc-editor.org/rfc/rfc8684
The text was updated successfully, but these errors were encountered: