fix(julia): fix parsing Julia v1.0 Manifests #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Octogonapus
changed the title
Octogonapus
force-pushed
the
fix_julia_v1.0_parsing
branch
from
f112af8 to
0c58a76
Compare
DmitriyLewen
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
@Octogonapus Thanks!
LGTM.
@knqyf263 take a look, when you have time, please.
|
Can we directly apply this fix to Trivy after this PR gets merged? I want to freeze go-dep-parser now. |
|
Indeed I could merge it into my Trivy PR if that's what you want. |
|
Yes,I'll let you know when we merge aquasecurity/trivy#6094. |
|
This has been merged into aquasecurity/trivy#5635 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia v1.0 manifests are now parsed correctly.
This fixes the problem raised in aquasecurity/trivy#5635